[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

2023-08-29 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. > @aprantl, how should I proceed with the swift branch? Should I create a new > branch in https://github.com/apple/swift and share it here so it's available > for whoever does the merge? Actually, I can just cherry-pick it myself, let's not worry about this. Repositor

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

2023-08-28 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. @aprantl, how should I proceed with the swift branch? Should I create a new branch in https://github.com/apple/swift and share it here so it's available for whoever does the merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

2023-08-28 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This should probably be a language-specific setting, but I see no problem in doing it this way right now, since there is practically only one language. Please update any REPL tests on the Swi

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

2023-08-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. + @aprantl for impact on the Swift REPL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158958/new/ https://reviews.llvm.org/D158958 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

2023-08-27 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. I have no problem with this conceptually. I'm not sure if there are any caveats or other things that need to be updated though, so please wait for more input before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

2023-08-27 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 553804. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158958/new/ https://reviews.llvm.org/D158958 Files: lldb/source/Core/CoreProperties.td Index: lldb/source/Core/CoreProperties.td

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

2023-08-27 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: bulbazord, JDevlieghere. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The REPL has a default tab size of 4 spaces, which seems to be a bit too m