[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

2023-08-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa7ca1175d0d4: [lldb] Fix & re-enable TestVSCode_completions on Darwin (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

2023-08-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D158893#4618503 , @wallace wrote: > Awesome!! Thank you for the prompt reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158893/new/ https://reviews.llvm.org/D158893 __

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

2023-08-25 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Awesome!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158893/new/ https://reviews.llvm.org/D158893 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

2023-08-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: wallace, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. The test was expecting `vector> &` while the test returned `vector &`. Since `verify_completions` doesn't support regex matching, side