[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

2023-09-08 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added inline comments. Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:780 PThreadMutex::Locker locker(m_mutex); if (m_rx_packets.empty()) { JDevlieghere wrote: > This is an RAII object, right? Can we just block scope it? Right now it

[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

2023-08-15 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:780 PThreadMutex::Locker locker(m_mutex); if (m_rx_packets.empty()) { This is an RAII object, right? Can we just block scope it? Right now it looks like we might

[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

2023-08-15 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord, jingham. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sani