This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe0053bc04e6b: [lldb] Bump SWIG minimum version to 4
(authored by JDevlieghere).
Herald added a project: LLDB.
Changed pri
JDevlieghere added a comment.
I didn't expect this to be controversial and I hear no objection so I'm going
to go ahead and land this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156804/new/
https://reviews.llvm.org/D156804
___
lldb-commit
DavidSpickett added a comment.
We are on 4.01 (AArch64), 4.02 (Arm) and 4.1.1 (Windows on Arm), so we have no
issues with this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156804/new/
https://reviews.llvm.org/D156804
___
lldb-commits maili
JDevlieghere added a comment.
Added the bot owners as reviewers for visibility.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156804/new/
https://reviews.llvm.org/D156804
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
JDevlieghere updated this revision to Diff 546093.
JDevlieghere added a comment.
Remove check for SWIG 3.0.9-3.0.10 in `python.swig`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156804/new/
https://reviews.llvm.org/D156804
Files:
lldb/bindings/python/python.swig
lldb/cmake/module
bulbazord added a comment.
`python.swig` has a few checks for SWIG versions 3.0.9 and 3.0.10, those can be
removed as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156804/new/
https://reviews.llvm.org/D156804
___
lldb-commits mailing l
JDevlieghere created this revision.
JDevlieghere added a reviewer: LLDB.
Herald added a project: All.
JDevlieghere requested review of this revision.
SWIG 4 was released in 2019 and has been the de-facto standard for a while now.
All bots are at least running SWIG 4.
Hans found out that after 66