[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG786bab433469: Display PC instead of for stack trace in vscode (authored by zhyty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https://reviews.llvm.org/D156732

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

zhyty updated this revision to Diff 546979. zhyty added a comment. remove a.out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https://reviews.llvm.org/D156732 Files: lldb/test/API/tools/lldb-vscode/stackTraceMissingFunctionName/Makef

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

zhyty updated this revision to Diff 546738. zhyty added a comment. - added a test case - rebased this commit on top of D156970 , which fixes a crash preventing me from testing this feature - addressed other comments Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

clayborg added a comment. You can copy this folder to a new test folder and adjust the test to verify: lldb/test/API/tools/lldb-vscode/stackTrace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https://reviews.llvm.org/D156732 ___

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Adding a test case for this is a good idea. In order to get the PC somewhere bad, you can probably make a function pointer that points to data, then try to branch there. The PC w

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

yinghuitan added a comment. Can you add a testcase for this? Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:768 +// hex string. +frame_name.clear(); +llvm::raw_string_ostream os(frame_name); I do not think this is needed? Comme

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

zhyty created this revision. Herald added a project: All. zhyty requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It isn't useful for users to see "" as a stack trace when lldb fails to symbolicate a stack frame. I've replaced "" with the va