[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb9087a696a6: [lldb] Clean up uses of UuidCompatibility.h (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156562/new/ https://reviews

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord added a comment. In D156562#4543743 , @jasonmolenda wrote: > This is fine to me but maybe instead of `ifndef apple` we could do a `if > __has_include()` and include the system header if it's avail. One reason I decided not to do this is becau

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord updated this revision to Diff 545289. bulbazord added a comment. Fix incorrect includes that @jasonmolenda pointed out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156562/new/ https://reviews.llvm.org/D156562 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord added a comment. In D156562#4543743 , @jasonmolenda wrote: > This is fine to me but maybe instead of `ifndef apple` we could do a `if > __has_include()` and include the system header if it's avail. I > must be misreading the patch but it see

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

jasonmolenda added a comment. This is fine to me but maybe instead of `ifndef apple` we could do a `if __has_include()` and include the system header if it's avail. I must be misreading the patch but it seems like you're changing the filename to AppleUuidCompatbility.h but the two places it's

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/AppleUuidCompatibility.h:15 // uuid_t is guaranteed to always be a 16-byte array typedef unsigned char uuid_t[16]; #endif // utility_UUID_COMPATIBILITY_H mib wrote: > May be this could be m

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

mib added inline comments. Comment at: lldb/include/lldb/Utility/AppleUuidCompatibility.h:15 // uuid_t is guaranteed to always be a 16-byte array typedef unsigned char uuid_t[16]; #endif // utility_UUID_COMPATIBILITY_H May be this could be moved to `lldb-types

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit does a few related things: - Removes u