Re: [Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-17 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255893: Patch cmake to allow detection of python 2.7.9+ (authored by aidandodds). Changed prior to commit: http://reviews.llvm.org/D15566?vs=42994&id=43127#toc Repository: rL LLVM http://reviews.llv

Re: [Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-17 Thread Aidan Dodds via lldb-commits
ADodds added a comment. Its currently present in the official 2.7.10 windows x64 python distro from python.org. Its also present in some of the prebuilds I have been using from here: http://p-nand-q.com/python/building-python-27-with-vs2010.html I can only assume that perhaps it signifies that

Re: [Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-16 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: krytarowski. krytarowski added a comment. In http://reviews.llvm.org/D15566#311998, @zturner wrote: > Where did you get this version of Python? I don't see anything wrong with > this patch, but I'm a little curious what this + means I think a patched version. I

Re: [Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-16 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Where did you get this version of Python? I don't see anything wrong with this patch, but I'm a little curious what this + means Repository: rL LLVM http://reviews.llvm.org/D15566 __

[Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-16 Thread Aidan Dodds via lldb-commits
ADodds created this revision. ADodds added a reviewer: zturner. ADodds added a subscriber: lldb-commits. ADodds set the repository for this revision to rL LLVM. Some distributions of python have their version defined as follows in patchlevel.h (note the '+'): #define PY_VERSION "2.7