yinghuitan updated this revision to Diff 541597.
yinghuitan added a comment.
Address review comments:
- clang-format
- Add coredump tests
- Add test against gs_base register
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155256/new/
https://reviews
DavidSpickett added a comment.
Caveat: I have 0 prior knowledge about these registers.
What's the testing story here? I see one for fs_base on a live process but none
for gs_base and neither for core files. If one test can hit all the code paths
those would hit, then fine, but otherwise this ne
clayborg added a comment.
LGTM. Anyone else have any issues?
Comment at:
lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64_with_base_shared.cpp:1-2
+//===-- RegisterInfos_x86_64_with_base_shared.cpp
+//--===//
+//
fix comment lin
yinghuitan updated this revision to Diff 541272.
yinghuitan edited the summary of this revision.
yinghuitan added a comment.
Revert x86_64 changes to reduce amount of changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155256/new/
https://review
