Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Todd Fiala via lldb-commits
Yeah I find some of these things not always obvious (I'm sure the docs are there, but I don't always find them ;-)). What I was hoping was this wasn't a python 2 vs. 3 thing. On Mon, Dec 14, 2015 at 7:30 PM, Zachary Turner wrote: > I tried to google the semantics of the in keyword, but Python >

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Zachary Turner via lldb-commits
I tried to google the semantics of the in keyword, but Python documentation is so horrible. I literally couldn't find a description of how it works :-/ Anyway, thanks! On Mon, Dec 14, 2015 at 7:27 PM Todd Fiala wrote: > This seems right: > > python > Python 2.7.10 (default, Oct 23 2015, 18:05:

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Todd Fiala via lldb-commits
This seems right: python Python 2.7.10 (default, Oct 23 2015, 18:05:06) [GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.59.5)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> s = 'abc' >>> 'bc' in 'abc' True >>> 'bc' in s True >>> 'clang' in 'clang' True O

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Siva Chandra via lldb-commits
On Mon, Dec 14, 2015 at 6:42 PM, Zachary Turner wrote: > zturner added inline comments. > > > Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:622 > @@ -621,3 +621,3 @@ > return list_or_lambda(value) > -elif isinstance(list_or_lambda, list): > -

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:622 @@ -621,3 +621,3 @@ return list_or_lambda(value) -elif isinstance(list_or_lambda, list): -return list_or_lambda is None or value is None or value in list_or_l

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Todd Fiala via lldb-commits
tfiala added a comment. Yep this fixed the issues I was having on OS X with the related change. Thanks, Siva! Repository: rL LLVM http://reviews.llvm.org/D15511 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Siva Chandra via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255584: Make few adjustments after r255542. (authored by sivachandra). Changed prior to commit: http://reviews.llvm.org/D15511?vs=42796&id=42802#toc Repository: rL LLVM http://reviews.llvm.org/D1551

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Siva Chandra via lldb-commits
sivachandra added a comment. I went ahead and committed this. Repository: rL LLVM http://reviews.llvm.org/D15511 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

2015-12-14 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added a reviewer: zturner. sivachandra added a subscriber: lldb-commits. http://reviews.llvm.org/D15511 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py ===