Re: [Lldb-commits] [PATCH] D15457: Remove hardcoded registers from Hexagon ABI

2015-12-11 Thread Ted Woodward via lldb-commits
ted updated this revision to Diff 42555. ted added a comment. Updated to check for invalid register numbers. http://reviews.llvm.org/D15457 Files: source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp Index: source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp ==

Re: [Lldb-commits] [PATCH] D15457: Remove hardcoded registers from Hexagon ABI

2015-12-11 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You want to check if each reg num is not LLDB_INVALID_REGNUM and return an appropriate error. http://reviews.llvm.org/D15457 ___ l

[Lldb-commits] [PATCH] D15457: Remove hardcoded registers from Hexagon ABI

2015-12-11 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: clayborg. ted added a subscriber: lldb-commits. The Hexagon ABI plugin uses hardcoded registers when setting up function calls. This is OK for the Hexagon simulator, but the register numbers are different on the gdbserver running on hardware. Chan