This revision was automatically updated to reflect the committed changes.
Closed by commit rL255525: Make debug info specification use categories system.
(authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D15428?vs=42550&id=42739#toc
Repository:
rL LLVM
http://reviews.l
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D15428#308401, @zturner wrote:
> In hindsight I wonder if I even needed to manually mark the test with a debug
> info. Maybe we can say that tests should *never* be
tberghammer added inline comments.
Comment at:
packages/Python/lldbsuite/test/lang/cpp/limit-debug-info/TestWithLimitDebugInfo.py:9
@@ -8,4 +8,3 @@
-@dwarf_test
-def test_with_dwarf(self):
-self.buildDwarf()
+@skipIf(debug_info=not_in(["dwarf"]))
+def te
zturner updated this revision to Diff 42550.
zturner added a comment.
Updated with comments from previous review. Also change the multiplication
logic to use a loop instead of writing each one separately.
http://reviews.llvm.org/D15428
Files:
packages/Python/lldbsuite/test/configuration.py
zturner added a comment.
In http://reviews.llvm.org/D15428#308131, @labath wrote:
> The interaction between the `add_test_categories` and the "magic test
> multiplier" is causing problems, which is evident in the fact how you needed
> to add the `@skip` decorator to make it work.
>
> It sounds
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
The interaction between the `add_test_categories` and the "magic test
multiplier" is causing problems, which is evident in the fact how you needed to
add the `@skip` decorator to mak
zturner created this revision.
zturner added reviewers: labath, tberghammer.
zturner added a subscriber: lldb-commits.
I'm not sure if I did this right, but the end result of this CL is removal of
the -N command line option, and making people go through the categories system
instead.
http://rev
zturner updated this revision to Diff 42452.
zturner added a comment.
Actually remove the -N command line option as well.
http://reviews.llvm.org/D15428
Files:
packages/Python/lldbsuite/test/configuration.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_ar
