Re: [Lldb-commits] [PATCH] D15379: Switch to gold linker on android x86, x86_64, arm

2015-12-10 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255240: Switch to gold linker on android x86, x86_64, arm (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D15379?vs=42295&id=42407#toc Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D15379: Switch to gold linker on android x86, x86_64, arm

2015-12-10 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: cmake/platforms/Android.cmake:124 @@ -123,1 +123,3 @@ +# Use gold linker and enable safe ICF in case of x86, x86_64 and arm +if ( ANDROID_ABI STREQUAL "x86"OR ovyalov wrote: > Just out of curiosity - you haven't

Re: [Lldb-commits] [PATCH] D15379: Switch to gold linker on android x86, x86_64, arm

2015-12-09 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. LGTM Comment at: cmake/platforms/Android.cmake:124 @@ -123,1 +123,3 @@ +# Use gold linker and enable safe ICF in case of x86, x86_64 and arm +if ( ANDROID_ABI STREQUAL "x86"OR Just out of curiosity -

Re: [Lldb-commits] [PATCH] D15379: Switch to gold linker on android x86, x86_64, arm

2015-12-09 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good http://reviews.llvm.org/D15379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D15379: Switch to gold linker on android x86, x86_64, arm

2015-12-09 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, ovyalov. tberghammer added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson. Switch to gold linker on android x86, x86_64, arm These architectures already using the gol