[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere added a comment. In D153644#891 , @jasonmolenda wrote: > It seems like this patch is really avoiding the sign extension of an int8_t > to int32_t in the process of being passed to printf. By casting it to > unsigned we've avoided the

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

jasonmolenda added a comment. It seems like this patch is really avoiding the sign extension of an int8_t to int32_t in the process of being passed to printf. By casting it to unsigned we've avoided the sign extension and getting the correct result, but it seems like you could have used a prin

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f40fc676df: [lldb] Print unprintable characters as unsigned (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D153644?vs=533985&id=534020#toc

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere added a comment. In D153644#679 , @bulbazord wrote: > Makes sense to me. Does it make sense to add a test case where we mix > "printable" characters with "non-printable" ones? I see you have a `\f` at > the end there, but that's a speci

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me. Does it make sense to add a test case where we mix "printable" characters with "non-printable" ones? I see you have a `\f` at the end there, but that's a special escap

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, DavidSpickett, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. When specifying the C-string format for dumping memory, we treat unprintable characters as signed. Whether a chara