[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG956f5c5f6de8: [lldb] Use SmallVector for handling register data (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett updated this revision to Diff 534596. DavidSpickett added a comment. Drop {} in one place now that the resize is not conditional. The logic there also seems faulty, but in other ways I will stay out of for now. I did attempt another sanitizers build and realised I should have been s

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett updated this revision to Diff 534580. DavidSpickett added a comment. Make a resize in EmulateInstructionARM64::EmulateLDPSTP uncondintional. Though in this case the register for an ldp/stp could only be an x register which is 8 bytes, so there would have been enough allocated alread

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett added a comment. > The sanitized bot on GreenDragon runs on Intel and I assume the "risky' > changes only apply to arm64 as that's the only architecture that needs to > scale beyond the default 256? Anyway I haven't seen the leaks issue you've > mentioned locally so I'm happy to r

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D153626#096 , @DavidSpickett wrote: > This assumes that the usual use case is: > > - Make a small vector. > - Resize it to what you

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett added reviewers: omjavaid, JDevlieghere, labath. DavidSpickett added a comment. This assumes that the usual use case is: - Make a small vector. - Resize it to what you need. - Use the content like an array. Every case I found matched that but still, it's not the safest API ever. So

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett created this revision. Herald added subscribers: ctetreau, atanasyan, jrtc27, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. Previously lldb was using arr