This revision was automatically updated to reflect the committed changes.
Closed by commit rL255499: Add failure paths to a few JSONNumber members
(authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D15355?vs=42706&id=42712#toc
Repository:
rL LLVM
http://reviews.llvm.or
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/lldb/Utility/JSON.h:148
@@ -147,3 +147,3 @@
-uint64_t
+int64_t
GetAsSigned() const;
Nice catch!
omjavaid updated this revision to Diff 42706.
omjavaid added a comment.
Sorry @tberghammer there was corruption in my setup showing changes which i
just made internally.
I have updated this diff as per suggestions.
LGTM?
http://reviews.llvm.org/D15355
Files:
include/lldb/Utility/JSON.h
s
tberghammer added a comment.
I don't know what correction you are referring to as I haven't made any change
in JSON.{h,cpp} since you created this patch but I am happy with the current
situation (no warning on clang)
http://reviews.llvm.org/D15355
___
omjavaid abandoned this revision.
omjavaid added a comment.
Correction made upstream by @tberghammer.
http://reviews.llvm.org/D15355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
labath added a subscriber: labath.
labath added a comment.
btw, if you use `llvm_unreachable("text")`, then you don't need the return
after that.
http://reviews.llvm.org/D15355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
tberghammer requested changes to this revision.
tberghammer added a comment.
This revision now requires changes to proceed.
These GetAs{...} functions should never fail in their current implementation as
we have only 3 different data type and all of them are handled. The new
function signatures
omjavaid created this revision.
omjavaid added a reviewer: tberghammer.
omjavaid added a subscriber: lldb-commits.
This patch updates GetAsUnsigned(), GetAsSigned(), and GetAsDouble() JSONNumber
functions to add failure check.
The previous code was generating compiler warnings for not being able
