[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack added a comment. verified, Windows buildbot is now green. https://lab.llvm.org/buildbot/#/builders/219 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llvm.org/D153390 _

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4071d22516: [lldb][Windows] Fix ZipFileResolver tests (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llv

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

kusmour accepted this revision. kusmour added a comment. The fix looks straightforward. And @splhack has verified locally. Accepting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llvm.org/D153390 ___

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack added a comment. Yes, in fact ZipFileResolverTest is the test what is running on Windows, and failing due to POSIX vs Windows path. This diff will fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llv

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Can we test this? I will ok to unblock windows bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llvm.org/D153

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D152759 introduced the Android .zip so file support, but it only considered POSIX path.