[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Sorry I missed the comments before landing, I've addressed those in https://github.com/llvm/llvm-project/commit/c7759df03825f63f8334d88c9525d655acfab685. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b73a2e82191: [LLDB] Add table formatting for register fields (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152917/new/ https:/

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/include/lldb/Target/RegisterFlags.h:96 + /// Produce a text table showing the layout of all the fields. Unamed/padding + /// fields wil

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett added a comment. I'm aware we likely have 10s of adhoc table printing functions across llvm and I'm surprised someone hasn't unified them yet. Which is to say, today I am not that person though I would like to collect a list of places that could benefit from it. Repository: r

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This will be used by the "register info" command to show the layout of register contents. For example if we have