[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

2023-06-21 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGba85f206fe6f: [lldb] Add "register info" command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152916/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

2023-06-14 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152916/new/ https://reviews.llvm.org/D152916

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

2023-06-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. I think "info" is a fairly safe name for this command. I thought about "register help" but then you could do "help register help" and while that's amusing it's also pretty silly. You might think at a glance "info" does something like check the register's value fo

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

2023-06-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added reviewers: jasonmolenda, labath, JDevlieghere. DavidSpickett added inline comments. Comment at: lldb/source/Core/DumpRegisterInfo.cpp:84 + +void lldb_private::DoDumpRegisterInfo( +Stream &strm, const char *name, const char *alt_name, uint32_t byte_size, --

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

2023-06-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new command that will show all the information lldb knows about a register. (lldb) register info