[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

This revision was automatically updated to reflect the committed changes. Closed by commit rG49f55b025d81: [lldb][Android] Add PlatformAndroidTest (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack added a comment. I will submit a diff to deal with how to use the AdbClient in PlatformAndroid later. Most likely we could use only one instance of AdbClient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Lets get this patch in so we have testing. We can work on caching the AdbClient internally in an ivar of PlatformAndroid in follow up patches. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

clayborg added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:204 // constraints - try "cat ..." as a fallback. - AdbClient adb(m_device_id); + AdbClientUP adb(GetAdbClient(error)); + if (error.Fail()) Do we want the P

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 532196. splhack added a comment. - s/AdbClientSP/AdbClientUP/g - Updated `Status &error` arg to `GetAdbClient` - Added error checks in AndroidPlatform for `GetAdbClient` - Added DownloadModuleSliceWithAdbClientError test for the GetAdbClient error Repository

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:209 - return adb.ShellToFile(cmd, minutes(1), destination); + return adb->ShellToFile(cmd, minutes(1), destination); } bulbazord wrote: > `GetAdbClient()` cal

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

bulbazord added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:209 - return adb.ShellToFile(cmd, minutes(1), destination); + return adb->ShellToFile(cmd, minutes(1), destination); } `GetAdbClient()` calls `make_unique`

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Very easy fix for this as suggested in code changes and this will be good to go Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.h:73 + typed

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531578. splhack added a comment. Fixed diff dependencies in order to fix CI https://reviews.llvm.org/B238938 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files:

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531500. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files: lldb/source/Plugins/Platform/Android/AdbClient.h lldb/source/Plugin

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531396. splhack added a comment. remove 'Depend on' from commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files: lldb/source/Plugins/Platform/Android/

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531389. splhack added a comment. rebase onto D152759 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files: lldb/source/Plugins/P

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531198. splhack added a comment. Herald added a subscriber: JDevlieghere. sync with D152759 new version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://revie

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added reviewers: clayborg, labath, lanza, srhines. splhack edited the summary of this revision. splhack updated this revision to Diff 531075. splhack added a comment. splhack updated this revi