[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe19339f5f8c1: [lldb] Identify Swift-implemented ObjC classes (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 542169. kastiglione added a comment. Redo ValueObjectDynamicValue::UpdateValue changes based on upstream testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 F

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 539359. kastiglione added a comment. Change `bool IsSwift()` to `LanguageType GetImplementationLanguage()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 Files:

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

bulbazord added a comment. My concerns have been addressed, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione added a comment. @bulbazord @augusto2112 hopefully this is a quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 539268. kastiglione added a comment. Refactor for better API layering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 Files: lldb/include/lldb/Target/LanguageRu

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

aprantl added inline comments. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:169 + if (known_type == lldb::eLanguageTypeObjC && + UseSwiftRuntime(*m_parent, exe_ctx)) { +runtime = process->GetLanguageRuntime(lldb::eLanguageTypeSwift); This is

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione added inline comments. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:119-123 +if (auto *runtime = llvm::dyn_cast_or_null( +process->GetLanguageRuntime(lldb::eLanguageTypeObjC))) + if (auto class_sp = runtime->GetClassDescriptor(valobj))

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

bulbazord added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:10 #include "lldb/Core/ValueObjectDynamicValue.h" +#include "Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h" #include "lldb/Core/Value.h" -

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Classes implemented in Swift can be exposed to ObjC. For