[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. Fixed Windows test failures in D153390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 ___ lldb-comm

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. ResolveSharedLibraryPathWithZipExisting and ResolveSharedLibraryPathWithZipMissing are failing on Windows. Looking into. https://lab.llvm.org/buildbot/#/builders/219/builds/3674 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

This revision was automatically updated to reflect the committed changes. Closed by commit rG12dee9d3cd76: [lldb][Android] Support zip .so file (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 532165. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h lldb/include/lldb/U

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531992. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h lldb/include/lldb/U

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531974. splhack added a comment. Added eFileKindInvalid with assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileReso

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1336 + // "zip_path!/so_path". Resolve the zip file path, .so file offset and size. + ZipFileResolver::FileKind file_kind; + std::string file_path; ---

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531969. splhack added a comment. Rename `ResolveBionicPath` to `ResolveSharedLibraryPath`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1336 + // "zip_path!/so_path". Resolve the zip file path, .so file offset and size. + ZipFileResolver::FileKind file_kind; + std::string file_path; --

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/include/lldb/Host/common/ZipFileResolver.h:30 + + static bool ResolveBionicPath(const FileSpec &file_spec, FileKind &file_kind, +std::string &file_path, mib wrote: > mib wrote: > > T

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

mib added inline comments. Comment at: lldb/include/lldb/Host/common/ZipFileResolver.h:30 + + static bool ResolveBionicPath(const FileSpec &file_spec, FileKind &file_kind, +std::string &file_path, mib wrote: > This function name s

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

mib added inline comments. Comment at: lldb/include/lldb/Host/common/ZipFileResolver.h:30 + + static bool ResolveBionicPath(const FileSpec &file_spec, FileKind &file_kind, +std::string &file_path, This function name sounds like th

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for reworking it! You may want to wait a little bit before landing so others have some time to look over it, but I don't see anything that should prevent this from going in. Rep

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531576. splhack added a comment. Fixed diff dependencies in order to fix CI https://reviews.llvm.org/B238937 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531499. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h lldb/include/lldb/U

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531394. splhack added a comment. remove 'Depends on' from commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFi

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:261-264 + if (const char *run_as = std::getenv("ANDROID_PLATFORM_RUN_AS")) +snprintf(run_as_cmd, sizeof(run_as_cmd), "run-as '%s' ", run_as); + else +run_as_cmd[0] = '\0'

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531384. splhack added a comment. rebase onto D152757 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Hos

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531195. splhack added a comment. - ZipFile: zip file parser in Utility - include/lldb/Utility/ZipFile.h - source/Utility/ZipFile.cpp - ZipFileResolver: bionic zip .so file resolver, depends on Host::FileSystem - include/lldb/Host/common/ZipFileResolver.

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES "Android") + list(APPEND ANDROID_SOURCES b

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord added inline comments. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES "Android") + list(APPEND ANDROID_SOURCES

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. @bulbazord thanks for reviewing! will address the types, formats. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES "A

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord added a comment. Herald added a subscriber: JDevlieghere. This is definitely useful to support, I had a few comments mostly about matching lldb's coding style. Also, are you running clang-format on your patches? There are a few places where I'm not sure if the formatting is right.

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack created this revision. Herald added subscribers: danielkiss, krytarowski. Herald added a project: All. splhack added reviewers: clayborg, labath, lanza, srhines. splhack published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In Android AP