Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2016-01-21 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. Yes, I believe so. http://reviews.llvm.org/D15209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2016-01-21 Thread Todd Fiala via lldb-commits
tfiala added a comment. Can this be closed out? http://reviews.llvm.org/D15209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2015-12-04 Thread Zachary Turner via lldb-commits
Thanks, I'll commit this later today then. On Fri, Dec 4, 2015 at 10:25 AM Todd Fiala wrote: > tfiala accepted this revision. > tfiala added a comment. > This revision is now accepted and ready to land. > > Hey Zachary, > > As best as I can tell, we don't need to do anything here, at least not o

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2015-12-04 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Hey Zachary, As best as I can tell, we don't need to do anything here, at least not on OS X El Capitan, because six is already included in the OS X Python distribution. I was scratching my he

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2015-12-04 Thread Todd Fiala via lldb-commits
tfiala added a comment. Looking at this now. http://reviews.llvm.org/D15209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2015-12-03 Thread Todd Fiala via lldb-commits
tfiala added a comment. Doesn't look like I can hit this until the morning. But it'll be first thing on my list. http://reviews.llvm.org/D15209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2015-12-03 Thread Todd Fiala via lldb-commits
tfiala added a comment. Yep - I can make sure this works on Xcode tonight. I'll either direct send you the diff or incorporate it with what you have here. It probably won't be until much later tonight, but I'll definitely hit this. http://reviews.llvm.org/D15209 ___

[Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2015-12-03 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: granata.enrico, tfiala. zturner added a subscriber: lldb-commits. I think this patch may require some xcode changes. This is because of the `from six.moves import reload_module`. In the CMake build as part of the swig wrapper python scrip