Re: [Lldb-commits] [PATCH] D15162: Have result formatter send bytes instead of strings

2016-01-21 Thread Todd Fiala via lldb-commits
tfiala added a comment. Is this ready to close out? http://reviews.llvm.org/D15162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15162: Have result formatter send bytes instead of strings

2015-12-02 Thread Todd Fiala via lldb-commits
tfiala added a comment. Okay I also had a chance to run it with the patch locally, and I didn't see any issues. http://reviews.llvm.org/D15162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [PATCH] D15162: Have result formatter send bytes instead of strings

2015-12-02 Thread Todd Fiala via lldb-commits
tfiala added a subscriber: tfiala. tfiala added a comment. Lgtm -Todd http://reviews.llvm.org/D15162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15162: Have result formatter send bytes instead of strings

2015-12-02 Thread Todd Fiala via lldb-commits
Lgtm -Todd > On Dec 2, 2015, at 2:28 PM, Zachary Turner wrote: > > zturner created this revision. > zturner added a reviewer: tfiala. > zturner added a subscriber: lldb-commits. > > http://reviews.llvm.org/D15162 > > Files: > packages/Python/lldbsuite/test/dotest_channels.py > packages/Pyth

[Lldb-commits] [PATCH] D15162: Have result formatter send bytes instead of strings

2015-12-02 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. http://reviews.llvm.org/D15162 Files: packages/Python/lldbsuite/test/dotest_channels.py packages/Python/lldbsuite/test/test_results.py Index: packages/Python/lldbsuite/test/test_results