[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

2023-05-26 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe31f99464216: [lldb] Improve error message when evaluating expression when not stopped (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D151497

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

2023-05-25 Thread Alex Langford via Phabricator via lldb-commits
bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. In D151497#4374495 , @JDevlieghere wrote: > In D151497#4374080 , @bulbazord > wrote: > >> I think it'

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

2023-05-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Expression/UserExpression.cpp:211 +error.SetErrorStringWithFormatv( +"unable to evaluate expression while the process is {0}: the process " +"must be stopped because the expression might requires allo

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

2023-05-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 525861. JDevlieghere added a comment. Rephrase error message for `UserExpression::Evaluate` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151497/new/ https://reviews.llvm.org/D151497 Files: lldb/source/Expression/UserExpression.cpp lldb/so

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

2023-05-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D151497#4374080 , @bulbazord wrote: > I think it's good to improve the error messaging but I think we can probably > do better. "Function caller" is specific to the internals of LLDB and isn't > really meaningful for man

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

2023-05-25 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a subscriber: kastiglione. mib added a comment. In D151497#4374080 , @bulbazord wrote: > I think it's good to improve the error messaging but I think we can probably > do better. "Function caller" is specific to the internals of LLDB and isn't

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

2023-05-25 Thread Alex Langford via Phabricator via lldb-commits
bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. I think it's good to improve the error messaging but I think we can probably do better. "Function caller" is specific to the internals of LLDB and isn't really meaningful for m

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

2023-05-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: jingham, aprantl, bulbazord, mib. Herald added a project: All. JDevlieghere requested review of this revision. When trying to run an expression after a process has existed, you currently are shown the following error message: (l