This revision was automatically updated to reflect the committed changes.
Closed by commit rG57154a63a07f: [lldb] Introduce FileSpec::GetComponents
(authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151399/new/
https://reviews.ll
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1241
+// We want the components in reverse order.
+std::reverse(path_parts.begin(), path_parts.end(
bulbazord updated this revision to Diff 525757.
bulbazord added a comment.
Convert return type to `std::vector`
Actually fix code so this thing compiles correctly
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151399/new/
https://reviews.llvm.org/D1
bulbazord added inline comments.
Comment at: lldb/include/lldb/Utility/FileSpec.h:420
+ /// A std::vector of std::strings for each path component.
+ std::vector GetComponents() const;
+
JDevlieghere wrote:
> bulbazord wrote:
> > JDevlieghere wrote:
> > > I'm
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Utility/FileSpec.h:420
+ /// A std::vector of std::strings for each path component.
+ std::vector GetComponents() const;
+
bulbazord wrote:
> JDevlieghere wrote:
> > I'm surprised this returns
bulbazord added inline comments.
Comment at: lldb/include/lldb/Utility/FileSpec.h:420
+ /// A std::vector of std::strings for each path component.
+ std::vector GetComponents() const;
+
JDevlieghere wrote:
> I'm surprised this returns a vector of `std::string
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Utility/FileSpec.h:420
+ /// A std::vector of std::strings for each path component.
+ std::vector GetComponents() const;
+
I'm surprised this returns a vector of `std::string`s and not
`llvm::
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch introduces FileSpec::GetComponents, a me
