EwanCrawford added a comment.
Thanks for fixing this Adrian
Repository:
rL LLVM
http://reviews.llvm.org/D15092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254338: Fix hang in global static initialization (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D15092?vs=41433&id=41435#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Ahh ok if there's already precedent for returning by reference then it's fine.
http://reviews.llvm.org/D15092
___
lldb-commits mailing list
lld
amccarth added inline comments.
Comment at:
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185
@@ -184,3 +184,3 @@
-static const ConstString FallbackStructName; // Print this as the
type name of a struct Element
zturner added inline comments.
Comment at:
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185
@@ -184,3 +184,3 @@
-static const ConstString FallbackStructName; // Print this as the
type name of a struct Element
amccarth created this revision.
amccarth added reviewers: EwanCrawford, zturner.
amccarth added a subscriber: lldb-commits.
A previous patch introduced a global static ConstString instance. On Windows,
this results in a hang because constructing the string pool appears to depend
on other global
