Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269332: Add CMake bits necessary for standalone build (authored by kamil). Changed prior to commit: http://reviews.llvm.org/D15067?vs=56970&id=57091#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-12 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a comment. In http://reviews.llvm.org/D15067#428146, @krytarowski wrote: > @Eugene.Zelenko do you agree with this patch and what @labath wrote? If CMake works that way, it's what I need :-) Repository: rL LLVM http://reviews.llvm.org/D15067 _

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-12 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. @Eugene.Zelenko do you agree with this patch and what @labath wrote? Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-12 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. In http://reviews.llvm.org/D15067#427848, @Eugene.Zelenko wrote: > In http://reviews.llvm.org/D15067#427834, @krytarowski wrote: > > > In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote: > > > > > I would like to see implemented

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-11 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a comment. In http://reviews.llvm.org/D15067#427834, @krytarowski wrote: > In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote: > > > I would like to see implemented my comment about LLVM_CONFIG and > > find_program(). > > > Could you first push this to clang? I

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-11 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote: > I would like to see implemented my comment about LLVM_CONFIG and > find_program(). Could you first push this to clang? I don't want to drift from clang myself. Repository: rL LLVM http://review

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-11 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a comment. I would like to see implemented my comment about LLVM_CONFIG and find_program(). Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-11 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Updated. Can I commit it this way as it is? Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-11 Thread Kamil Rytarowski via lldb-commits
krytarowski retitled this revision from "Design building out of sources" to "Add CMake bits necessary for standalone build". krytarowski updated this revision to Diff 56970. Repository: rL LLVM http://reviews.llvm.org/D15067 Files: cmake/modules/LLDBStandalone.cmake scripts/CMakeLists.txt