[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdb814552132d: [lldb] Delay removal of persistent results (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. thank you @jingham, that is great feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522875. kastiglione added a comment. - Explicitly control expression evaluation options for suppressing persistent result - Use the ValueObject's display language instead of the CU or frame's language Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

jingham added a comment. This seems fine in general, with one quibble: IIUC, the "indirect" removal of persistent results which you are trying to avoid happens here: lldb::ExpressionResults UserExpression::Execute(DiagnosticManager &diagnostic_manager, ExecutionCon

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. s/frame pointer/pointer to StackFrame/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522384. kastiglione added a comment. check frame pointer before calling GuessLanguage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 Files: lldb/source/Command

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. This change is tested using the original tests from D144044 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 __

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522354. kastiglione added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 Files: lldb/source/Commands/CommandObjectDWIMPrint.cpp lldb/source

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up to "Suppress persistent result when running po" (D144044 <