Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-12-01 Thread Abhishek via lldb-commits
abhishek.aggarwal added a comment. Comments Inlined. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:853-854 @@ +852,4 @@ +{ +if (log) +log->Printf("NativeRegisterContextLinux_x86_64::%s ptrace APIs

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-12-01 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:853-854 @@ +852,4 @@ +{ +if (log) +log->Printf("NativeRegisterContextLinux_x86_64::%s ptrace APIs failed to read XSAV

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-12-01 Thread Abhishek via lldb-commits
abhishek.aggarwal added a comment. Hi Pavel and Tamas I enabled logs in case ptrace API fails to read FXSAVE/XSAVE area. This will serve as an indicator to find the reason of failure if register read fails. http://reviews.llvm.org/D15042 ___ lldb-

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-12-01 Thread Abhishek via lldb-commits
abhishek.aggarwal updated this revision to Diff 41489. abhishek.aggarwal added a comment. Added Loggings An indication through logs in case ptrace API fails to read FXSAVE/XSAVE area. http://reviews.llvm.org/D15042 Files: packages/Python/lldbsuite/test/functionalities/return-value/TestRetur

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-12-01 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. Looks good, and as it only effects Linux you can commit it just based on the review from Pavel http://reviews.llvm.org/D15042 ___ lldb-commi

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-12-01 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D15042 ___ lldb-commits mailing list lldb

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-12-01 Thread Abhishek via lldb-commits
abhishek.aggarwal added a comment. Hello Greg Is there anyone else , except the reviewers already included for the patch, I should put as the reviewer for this patch ? http://reviews.llvm.org/D15042 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-11-30 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I can't intelligently comment on low level ptrace stuff, so I will defer to others that can. http://reviews.llvm.org/D15042 ___ lldb-commits mail

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-11-30 Thread Abhishek via lldb-commits
abhishek.aggarwal updated this revision to Diff 41382. abhishek.aggarwal added a comment. Removed assert if ptrace API fails http://reviews.llvm.org/D15042 Files: packages/Python/lldbsuite/test/functionalities/return-value/TestReturnValue.py source/Plugins/Process/Linux/NativeRegisterContex

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-11-27 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:849-850 @@ -844,2 +848,4 @@ m_fpr_type = eFPRTypeFXSAVE; +assert (const_cast(this)->ReadFPR().Success() && +"ptrace APIs