This revision was automatically updated to reflect the committed changes.
Closed by commit rG81be68062f49: [lldb][nfc] Simplify DebugRanges class
(authored by fdeazeve).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150363/new/
https://reviews.llvm.
rastogishubham added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32
- typedef std::map range_map;
- typedef range_map::iterator range_map_iterator;
- typedef range_map::const_iterator range_map_const_iterator;
- range_map m_range_map
bulbazord accepted this revision.
bulbazord added a comment.
LGTM! I know we have this pattern in many places in LLDB. It's good to see this
work being done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150363/new/
https://reviews.llvm.org/D15036
fdeazeve added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32
- typedef std::map range_map;
- typedef range_map::iterator range_map_iterator;
- typedef range_map::const_iterator range_map_const_iterator;
- range_map m_range_map;
+ s
rastogishubham accepted this revision.
rastogishubham added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32
- typedef std::map range_map;
- typedef range_map::iterator range_map_iterator;
fdeazeve created this revision.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Most of the code changed here dates back to 2010, when LLDB was first
introduced upstream, as such it benefits from a slig
