This revision was automatically updated to reflect the committed changes.
Closed by commit rG586414927418: [lldb] Simplify Log::PutString (NFC) (authored
by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150160/new/
https://reviews.llvm
kastiglione updated this revision to Diff 520541.
kastiglione added a comment.
Update comments too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150160/new/
https://reviews.llvm.org/D150160
Files:
lldb/source/Utility/Log.cpp
Index: lldb/source
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lldb/source/Utility/Log.cpp:135
-void Log::PutCString(const char *cstr) { Printf("%s", cstr); }
-void Log::PutString(llvm::StringRef str) { PutCString(
kastiglione created this revision.
kastiglione added reviewers: mib, bulbazord.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
- As no format string is involved, avoid unecessary call into `Printf`
