[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4f3f5225df7: [lldb] Remove FileSpec::GetLastPathComponent (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https://review

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. Given the current behavior, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https://reviews.llvm.org/D149663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. In D149663#4313123 , @bulbazord wrote: > In D149663#4313112 , @mib wrote: > >> @bulbazord What if the FileSpec is pointing to a directory instead of a file >> ? What would `GetFilename` retur

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

bulbazord added a comment. In D149663#4313112 , @mib wrote: > @bulbazord What if the FileSpec is pointing to a directory instead of a file > ? What would `GetFilename` return in that case compared to > `GetLastPathComponent` ? FileSpec chops everything

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. @bulbazord What if the FileSpec is pointing to a directory instead of a file ? What would `GetFilename` return in that case compared to `GetLastPathComponent` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https:

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https://reviews.llvm.org/D149663 ___

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. As far a