clayborg added a comment.
I am fine with adding a new platform GDB remote packet that queries for a list
of processes that we need to connect to after we attach. It might be nice for
clients to be able to vend N number of processes that should be attached to
when the platform is connected to. T
labath added a comment.
FWIW, I like Greg's idea. The operation seems quite intuitive to me: "platform
connect" connects to the platform, and if that happens to have a process ready,
then it sets that up as well..
http://reviews.llvm.org/D14952
__
tberghammer added a comment.
I decided to go with the "platform process connect" command as it connects to
both to a platform and to a process instances at the same time but I agree it
is not very clear.
We can make this the default functionality for "platform connect" but then we
have to add
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I am not sure that I like this new "platform process connect" command as it
isn't really clear what this command does. "platform connect" connects to the
remote platform, "proces
tberghammer added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py:13
@@ +12,3 @@
+def test_platform_process_connect(self):
+if not lldb.remote_platform:
+self.skipTest("On
tberghammer updated this revision to Diff 41312.
tberghammer marked 4 inline comments as done.
tberghammer added a comment.
Improve the test based on the comments
http://reviews.llvm.org/D14952
Files:
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/lldbtest.py
packages/Pytho
labath added a comment.
Thank you for writing the test. I have just a couple of more comments and them
I'm done... :)
Please wait for @clayborg to sign off on this as well.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/platform-process-connect/TestPlatformProce
tberghammer marked an inline comment as done.
Comment at: source/Commands/CommandObjectPlatform.cpp:2040-2041
@@ -1968,13 +2039,4 @@
"platform process",
"A set of commands to query, launch and attach
to platform pr
tberghammer updated this revision to Diff 41266.
tberghammer added a comment.
Add test
http://reviews.llvm.org/D14952
Files:
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
packages/Python/lldbsuite/test/tools/lldb-server/platform-pro
labath added a comment.
Seems like a reasonable thing to do. However, we should first add a test for
the new functionality.
Comment at: source/Commands/CommandObjectPlatform.cpp:2041
@@ -1969,3 +2040,3 @@
"A set of commands to query, launch and
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, emaste.
Create new "platform process connect" command
The standard remote debugging workflow with gdb is to st
11 matches
Mail list logo
