[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. @jingham, in my use case, I'm exposing a minified LLDB client remotely, so the user won't have access to script command nor the SB API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. -> https://reviews.llvm.org/D149379 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

jingham added a comment. In D149312#4302449 , @wallace wrote: > Sure You can probably just add something to TestCommandDelete.py. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

jingham added a comment. This also seems a bit Quixotic to me. Unless you are also planning to remove the `script` command, there's nothing you can do in the command line that you can't do with the SB API so you aren't actually removing any functionality, just making it slightly less convenien

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. Sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

jingham added a comment. This was added without a test. Can you add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1465cd49efc: [lldb] Create a way to force remove commands (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace updated this revision to Diff 517399. wallace added a comment. remove whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

rriddle accepted this revision. rriddle added a comment. LGTM with comment addressed, and white space changes dropped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 _

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

bzcheeseman accepted this revision. bzcheeseman added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:329 + /// is provided, the command is removed regardless of its removable status. + bool Remove

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some LLDB set ups need to hide certain commands for security reasons, so I'm adding a flag that allows removing non-user co