[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord abandoned this revision. bulbazord added a comment. Thanks for the reviews and suggestions. I took a step back and looked at DWARFAbbreviationDeclaration and DWARFAttribute in more detail and I've decided I'm going to take this in a slightly different direction. I don't want to repurp

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61 uint8_t m_has_children = 0; - DWARFAttribute::collection m_attributes; }; kastiglione wrote: > With this change, can the following be removed

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

kastiglione added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61 uint8_t m_has_children = 0; - DWARFAttribute::collection m_attributes; }; With this change, can the following be removed from` DWARFAttribu

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

labath added a comment. I guess the most efficient (performance- and memory-wise) approach would be to have a global (well, scoped to a DWARFUnit or something) array of DWARFAttribute objects, and have the individual abbreviations just store pointers/indexes to that. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

JDevlieghere added a comment. In D149214#4300547 , @bulbazord wrote: > In D149214#4300491 , @aprantl wrote: > >> Did you also measure the extra memory consumption? I would be surprised if >> this mattered, but we

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord added a comment. In D149214#4300491 , @aprantl wrote: > Did you also measure the extra memory consumption? I would be surprised if > this mattered, but we do parse a lot of DWARF DIEs... > > Generally this seems fine. I compared the memory pro

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

aprantl added a comment. Did you also measure the extra memory consumption? I would be surprised if this mattered, but we do parse a lot of DWARF DIEs... Generally this seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149214/new/ https:/

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While measuring some performance in LLDB I noticed that we were spendi