[Lldb-commits] [PATCH] D148823: Make diagnostics API safer to use

2023-04-21 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG737820e6d6e2: Make diagnostics API safer to use (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D148823: Make diagnostics API safer to use

2023-04-20 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib accepted this revision. mib added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148823/new/ https://reviews.llvm.org/D148823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D148823: Make diagnostics API safer to use

2023-04-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148823/new/ https://reviews.llvm.org/D148823 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D148823: Make diagnostics API safer to use

2023-04-20 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added reviewers: kastiglione, JDevlieghere, Michael137. Herald added a project: All. aprantl requested review of this revision. I received a crash report in DiagnosticManager that was causes by a nullptr diagnostic having been added. The API allows passing i