[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rGce7a54a27c09: [lldb] Add `operator StringRef` to ConstString (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://re

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

fdeazeve added a comment. > since ConstStrings live forever So long as this is true, I don't see any pitfalls either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://reviews.llvm.org/D148175 _

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

aprantl accepted this revision. aprantl added a comment. Okay, then let the refactor fest begin! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://reviews.llvm.org/D148175 ___ lldb-commit

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

JDevlieghere accepted this revision. JDevlieghere added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://reviews.llvm.org/D148175 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. In D148175#4263217 , @aprantl wrote: > I understand that the opposite direction is explicit because actual work is > being done. In this d

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

aprantl added a comment. I understand that the opposite direction is explicit because actual work is being done. In this direction, it shouldn't affect memory management (since ConstStrings live forever) or performance, so I think this is good (and very convenient!). Does anyone else see a prob

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a `StringRef` conversion function to `ConstString`.