[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere added a comment. I didn't see this until now. I'll update the test. We shouldn't need strip for this test but we're sharing the Makefile for `SymbolFileJSON`. I'll see if it makes more sense to split up the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

DavidSpickett added subscribers: omjavaid, DavidSpickett. DavidSpickett added a comment. FYI this test is failing on our Windows on Arm bot due to not finding `strip`: https://lab.llvm.org/buildbot/#/builders/219/builds/2164/steps/6/logs/stdio I see other uses so not sure why this one isn't work

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

labath added inline comments. Comment at: lldb/test/API/macosx/symbols/TestObjectFileJSON.py:82 +} +self.emitJSON(data, json_object_file) + The test was (95%!) flaky because the two generated files had the same timestamp (and so lldb considered t

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e5cdbf07e6d: [lldb] Make ObjectFileJSON loadable as a module (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148062/new/ https://reviews.llvm.org/D148062 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere updated this revision to Diff 513045. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Address @mib's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148062/new/ https://reviews.llvm.org/D148062 Files: lldb/include/lldb/Core

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Core/Section.cpp:683-684 + llvm::json::ObjectMapper o(value, path); + return o && o.map("name", section.name) && o.map("type", section.type) && + o.map("size", sec

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

mib added inline comments. Comment at: lldb/lldb/test/API/macosx/symbols/TestObjectFileJSON.py:12 + +class TestObjectFileJSOn(TestBase): +TRIPLE = "arm64-apple-macosx13.0.0" nit Comment at: lldb/source/Core/Section.cpp:683-684 + llvm::json

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere updated this revision to Diff 512963. JDevlieghere added a comment. Fix bug in ObjectFileJSON where we wouldn't read the rest of the file and fail parsing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148062/new/ https://reviews.llvm.org/D148062 Files: lldb/include/lld

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere updated this revision to Diff 512946. JDevlieghere added a comment. - Improve error reporting - Fix bug CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148062/new/ https://reviews.llvm.org/D148062 Files: lldb/include/lldb/Core/Section.h lldb/include/lldb/Symbol/ObjectFil

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere created this revision. JDevlieghere added reviewers: mib, jingham. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds support for creating modules from JSON object files. This is necessary for crashlogs (see c17a1f3df70b