This revision was automatically updated to reflect the committed changes.
Closed by commit rG2b6c5bb995be: [lldb-vscode] Implement RestartRequest
(authored by jgorbe).
Changed prior to commit:
https://reviews.llvm.org/D147831?vs=512305&id=518866#toc
Repository:
rG LLVM Github Monorepo
CHANG
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
lgtm!
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1983
+ g_vsc.debugger.SetAsync(true);
+ LaunchProcess(*g_vsc.last_launch_or_attach_request);
+
j
jgorbe added inline comments.
Comment at: lldb/tools/lldb-vscode/VSCode.h:152
bool is_attach;
+ // The process event thread normally responds to process exited events by
+ // shutting down the entire adapter. When we're restarting, we keep the id of
labath w
wallace added inline comments.
Comment at: lldb/source/API/SBProcess.cpp:772
- return (event.GetBroadcasterClass() == SBProcess::GetBroadcasterClass()) &&
- !EventIsStructuredDataEvent(event);
+ return Process::ProcessEventData::GetEventDataFromEvent(event.get()) !=
+
labath added a comment.
Looks ok-ish, though I don't feel entirely comfortable approving lldb-vscode
changes. @wallace, do you have any thoughts on this?
Comment at: lldb/tools/lldb-vscode/VSCode.h:152
bool is_attach;
+ // The process event thread normally responds to proc
jgorbe added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147831/new/
https://reviews.llvm.org/D147831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jgorbe marked 2 inline comments as done.
jgorbe added inline comments.
Comment at: lldb/tools/lldb-vscode/VSCode.h:146
+ // arguments if we get a RestartRequest.
+ llvm::json::Object last_launch_or_attach_request;
lldb::tid_t focus_tid;
rupprecht wrote:
> st
jgorbe updated this revision to Diff 512305.
jgorbe added a comment.
Addressed review comments.
- Changed `last_launch_or_attach_request` to be a
`std::optional` so we can check if it has been set. Also
check for `nullopt` in request_restart.
- Made `request_attach` also set `last_launch_or_att
rupprecht added inline comments.
Comment at: lldb/tools/lldb-vscode/VSCode.h:146
+ // arguments if we get a RestartRequest.
+ llvm::json::Object last_launch_or_attach_request;
lldb::tid_t focus_tid;
std::optional? And then we can raise an error if the client
jgorbe created this revision.
jgorbe added reviewers: clayborg, wallace, labath, rupprecht.
jgorbe added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
jgorbe requested review of this revision.
This is an optional request, but supporting it makes the experie
10 matches
Mail list logo
