This revision was automatically updated to reflect the committed changes.
Closed by commit rGde5f96e99aed: [lldb] Add unittests for a few FileSpec
methods (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147801/new/
https://rev
mib accepted this revision.
mib added inline comments.
Comment at: lldb/include/lldb/Utility/FileSpec.h:330
/// filename has no extension, ConstString(nullptr) is returned. The dot
- /// ('.') character is not returned as part of the extension
+ /// ('.') character is the fi
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147801/new/
https://reviews.llvm.org/D147801
___
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Utility/FileSpec.h:330
/// filename has no extension, ConstString(nullptr) is returned. The dot
- /// ('.') character is not returned as part of the extension
+ /// ('.') character is the first character in th
mib added inline comments.
Comment at: lldb/include/lldb/Utility/FileSpec.h:330
/// filename has no extension, ConstString(nullptr) is returned. The dot
- /// ('.') character is not returned as part of the extension
+ /// ('.') character is the first character in the returne
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, jingham, mib, clayborg.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This adds tests for:
- FileSpec::TestFileNameExtension
