[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

This revision was automatically updated to reflect the committed changes. Closed by commit rGd557384b43d3: [LLDB] Fix for D139955 Summary: (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507855. ayermolo added a comment. fixed up refs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp l

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo added a comment. In D146659#4217557 , @clayborg wrote: > Must be relocations causing the stuff to not match up to the llvm-dwarfdump > output. Looked through llvm-dwarfdump code. Yep. since relocation exists, it just returns an addend which is

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Must be relocations causing the stuff to not match up to the llvm-dwarfdump output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:11 +# CHECK: 0x006e: adding range [0x-0x001f) +# CHECK-SAME: which has a base that is less than the function's low PC 0x0021. +# CHE

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg added a comment. FYI: This might be because we are using a .o file and relocations are being applied internally!? Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:11 +# CHECK: 0x006e: adding range [0x-0x001f) +# CH

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:11 +# CHECK: 0x006e: adding range [0x-0x001f) +# CHECK-SAME: which has a base that is less than the function's low PC 0x0021. +# CHE

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507812. ayermolo added a comment. updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp ll

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg added a comment. Fix the error message to check for the exact error message and this is good to go. Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:10 + +# CHECK: which has a base that is less than the function's low PC + might

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507528. ayermolo added a comment. updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp ll

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507526. ayermolo added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg added a comment. Is there no test case catching this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing a small typo. Repository: rG LLVM Github Monorepo https://revie