This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGef006eb0bc5e: [CodeView] Add source languages ObjC and
ObjC++ (authored by sgraenitz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6
+; ASM: .short 4412# Record kind: S_COMPILE3
+; ASM-NEXT: .long 17
sgraenitz added inline comments.
Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6
+; ASM: .short 4412# Record kind: S_COMPILE3
+; ASM-NEXT: .long 17 # Flags and language
+; ASM-NEXT: .short 208 # CPUType
--
sgraenitz updated this revision to Diff 506100.
sgraenitz marked 7 inline comments as done.
sgraenitz added a comment.
Cut down check-lines
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146221/new/
https://reviews.llvm.org/D146221
Files:
lldb/so
DavidSpickett added inline comments.
Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6
+; ASM: .short 4412# Record kind: S_COMPILE3
+; ASM-NEXT: .long 17 # Flags and language
+; ASM-NEXT: .short 208 # CPUType
--
DavidSpickett added inline comments.
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142
+/// These values correspond to the CV_CFL_LANG enumeration in the Microsoft
+/// Debug Interface Access SDK
enum SourceLanguage : uint8_t {
sgraenitz wrote:
> D
sgraenitz added a comment.
Maybe I should have noted immediately, that this is mostly following the change
for Rust from https://reviews.llvm.org/D115300
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142
+/// These values correspond to the CV_CFL_LANG enumeration
DavidSpickett added inline comments.
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142
+/// These values correspond to the CV_CFL_LANG enumeration in the Microsoft
+/// Debug Interface Access SDK
enum SourceLanguage : uint8_t {
Could put the same l
sgraenitz created this revision.
sgraenitz added reviewers: rnk, zturner, compnerd, aleksandr.urakov.
Herald added a subscriber: hiraditya.
Herald added a project: All.
sgraenitz requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added a subscriber: lldb-commits.
This pat
