[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

2023-03-16 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath added a comment. Hey, it looks like the reland of this is causing issues with the Fuchsia toolchain build: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8786444992328058977/overview Seems that it's only legal to call AppendBounds if you first check

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

2023-03-15 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaf38530ee29c: [lldb] Refactor CrashReason (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146043/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

2023-03-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146043/new/ https://reviews.llvm.org/D146043 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

2023-03-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added reviewers: labath, JDevlieghere. DavidSpickett added a comment. Or in other words "make it look like UnixSignals on the inside". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146043/new/ https://reviews.llvm.org/D146043 ___

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

2023-03-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added a subscriber: emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. So that there is only one function that NativeThreads call, which takes a sig