[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb78886246da: [lldb] Add test for unavailable registers (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/ https://revie

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/TestRegistersUnavailable.py:43-53 +self.expect("register read --all", patterns=[ +"(?sm)^general purpose registers:\n" +

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

rupprecht accepted this revision. rupprecht added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/commands/register/register/TestRegistersUnavailable.py:43-53 +self.expect("register read --all", patterns=[ +"(?sm)^g

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett updated this revision to Diff 507035. DavidSpickett added a comment. Remove the need for regex, with the tradeoff that you need the X86 backend which is pretty common to have. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett planned changes to this revision. DavidSpickett added a comment. On second thought I think you can do this without XML, I'll figure that out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/ https://reviews.llvm.org/D145940

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added a comment. The non XML way to do this is just reading bogus register names (and is already tested). However that's all or nothing so it doesn't prove that when there is a mix of available and unavailable registers the command works correctly. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added a comment. It's not in that dir because it's testing how the register command handles missing registers, rather than how the gdb client does. It assumes that the gdb client is correctly doing its job. And it seemed like the place one would look if you wondered whether there

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

rupprecht added a comment. Seems like most xml-based tests like this are in `lldb/test/API/functionalities/gdb_remote_client`, is there a reason this is not in that package too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/ https://re

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/ https://reviews.llvm.org/D145940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/TestRegistersUnavailable.py:57 +"other:\n" +"1 registers were unavailable."]) The only difference here if you have the x86 backend vs. not, is that

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Prior to this the only check was that we did not print this message when reading registers that should exist. I