Re: [Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

2015-11-12 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rL252950: Implement RegisterContext for Mini Dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D14591?vs=39978&id=40082#toc Reposi

Re: [Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

2015-11-12 Thread Adrian McCarthy via lldb-commits
amccarth marked 3 inline comments as done. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py:40 @@ +39,3 @@ +thread = self.process.GetThreadAtIndex(0) +# The crash is in main, so there should be one frame on the stack.

Re: [Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

2015-11-12 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py:40 @@ +39,3 @@ +thread = self.process.GetThreadAtIndex(0) +# The crash is in main, so there should be one frame on the stack. +sel

[Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

2015-11-11 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. The old RegisterContextWinMiniDump stub is replaced with x86 and x64 implementations that derive from the common windows register contexts. ProcessWindowsMiniDump grabs the WinAPI CONTE