sas abandoned this revision.
sas added a comment.
Not required anymore.
http://reviews.llvm.org/D14507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas added a comment.
Ok I'll integrate that with the code that uses m_address_class_map.
http://reviews.llvm.org/D14507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer requested changes to this revision.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2191-2213
@@ -2170,25 +2190,25 @@
if (arch.GetMachine() == llvm::Triple::arm)
{
if (symbol_type == eSymbolTypeCode)
clayborg added a comment.
See Inlined comment.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:975-997
@@ -974,5 +974,25 @@
{
-// No entry in the address class map before the address. Return
-// default address class for an address in a code sect
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
You should populate the m_address_class_map in ObjectFileELF::ParseSymbols() as
this is where the m_address_class_map is already being populated. For ARM
symbols, just check the
sas created this revision.
sas added reviewers: tberghammer, clayborg.
sas added a subscriber: lldb-commits.
Herald added a subscriber: rengolin.
This was GetAddressClass' behavior before. This is required when
debugging binaries that don't have mapping symbols ($a, $t, etc). These
binaries will o
