[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

labath added a comment. Yes, that is the correct process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/ https://reviews.llvm.org/D144240 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

buttaface added a comment. I looked online and it appears that you nominate a trunk commit by opening a github issue ? I am new to this LLVM workflow myself, but here is what appears to be a recent example

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay added a comment. Sure, you are right that it should be pulled back into release/16.x, and I expect it to apply cleanly. However, I don't know what mechanism should bve used to create cherry-pick changes into release branches on GitHub: (1) this was not a GitHub issue/PR, so I gues

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

buttaface added a comment. @emrekultursay, do you think you can get this into the release/16.x branch next? It fixed lldb for us on the Android Termux app . Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8bd179a1738: Clear read_fd_set if EINTR received (authored by emrekultursay, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay added a comment. Can you submit the change for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/ https://reviews.llvm.org/D144240 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay added a comment. > As discussed internally, it would be great if we could remove this > android-specific code path (by removing support for OS versions which > necessitated it). For now, Android Studio still requires the ability to debug API levels 16-19. The next time that min A

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Nice catch. As discussed internally, it would be great if we could remove this android-specific code path (by removing support for OS versions which necessitated it). Repository: rG LLVM

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay updated this revision to Diff 498257. emrekultursay added a comment. Herald added a subscriber: JDevlieghere. Fix indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/ https://reviews.llvm.org/D144240 Files: lldb/s

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay created this revision. Herald added a project: All. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Leaving bits uncleared set causes callbacks to be triggered even though there are no events to process. Starting