Re: [Lldb-commits] [PATCH] D14342: Enable absolute imports in lldbsuite

2015-11-05 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Okay, looks good then. Thanks, Zachary! http://reviews.llvm.org/D14342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

Re: [Lldb-commits] [PATCH] D14342: Enable absolute imports in lldbsuite

2015-11-05 Thread Zachary Turner via lldb-commits
zturner added a comment. In http://reviews.llvm.org/D14342#282346, @tfiala wrote: > Does this mean that if we import third party modules, and since you have > embedded them into our package, that we would have to change third party code > to adhere to our packaging structure? If not, fine. If

Re: [Lldb-commits] [PATCH] D14342: Enable absolute imports in lldbsuite

2015-11-05 Thread Todd Fiala via lldb-commits
tfiala added a comment. Does this mean that if we import third party modules, and since you have embedded them into our package, that we would have to change third party code to adhere to our packaging structure? If not, fine. If so, this was one of the areas I mentioned that I was concerned

[Lldb-commits] [PATCH] D14342: Enable absolute imports in lldbsuite

2015-11-04 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. Enable absolute imports in lldbsuite. Absolute imports were introduced in Python 2.5 as a feature (e.g. from __future__ import absolute_import), and made default in Python 3.