[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff636729d06: [lldb] Accept negative indexes in __getitem__ (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/ https://rev

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

kastiglione updated this revision to Diff 494783. kastiglione added a comment. Add a couple tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/ https://reviews.llvm.org/D143282 Files: lldb/bindings/interface/SBBreakpoint.i lldb/bin

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

bulbazord added a comment. A simple test would be what you did in your commit summary, trying to get `thread.frame[-1]` and verifying that it's the correct frame. LGTM with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/ https://

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

mib added a comment. In D143282#4103165 , @kastiglione wrote: > I wondered what to do about tests. Should I pick one of these to test? Just > doesn't seem worth tests for each… Yeah, that sounds good to me :) Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

kastiglione added a comment. I wondered what to do about tests. Should I pick one of these to test? Just doesn't seem worth tests for each… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/ https://reviews.llvm.org/D143282

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. This is nice although I wish there was a built way to do it. LGTM with a test :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/ https://rev

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, bulbazord. Herald added a subscriber: arphaman. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To the Python bindin