tfiala closed this revision.
tfiala added a comment.
Closed by commit:
$ svn commit
Sendinglldb.xcodeproj/project.pbxproj
Sendingscripts/Python/finish-swig-Python-LLDB.sh
Sendingscripts/Python/finishSwigPythonLLDB.py
Sendingsource/Host/macosx/Host.mm
Se
tfiala added a comment.
I'm out the next couple days at the LLVM conference. I'm going to put this in.
We'll revert it out if it causes any trouble on Windows and fix it up.
http://reviews.llvm.org/D14169
___
lldb-commits mailing list
lldb-commit
tfiala updated this revision to Diff 38715.
tfiala added a comment.
Fixed up one missed spot, the python-based class completion script.
I think the original clean build and test run on Linux missed this because I
don't think we actually use it on Linux. It's primarily useful on OS X 10.11
and
tfiala added a comment.
In http://reviews.llvm.org/D14169#277587, @tfiala wrote:
> > scripts/Python/finish-swig-Python-LLDB.sh
>
>
> Hmm I think there is a python implementation of this script that I may have
> missed. Checking on that now.
Yes there is. I need to adjust one other place. I'
tfiala added a comment.
> scripts/Python/finish-swig-Python-LLDB.sh
Hmm I think there is a python implementation of this script that I may have
missed. Checking on that now.
http://reviews.llvm.org/D14169
___
lldb-commits mailing list
lldb-commi
tfiala added a comment.
In http://reviews.llvm.org/D14169#277545, @labath wrote:
> Looks good.
>
> argdumper should probably go to /usr/libexec, but then I guess we won't be
> able to find it, so that's a different story...
Exactly right. That will require more work.
http://reviews.llvm.org/
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good.
argdumper should probably go to /usr/libexec, but then I guess we won't be able
to find it, so that's a different story...
http://reviews.llvm.org/D14169
_
tfiala created this revision.
tfiala added reviewers: labath, zturner, jasonmolenda.
tfiala added a subscriber: lldb-commits.
Distributions that put lldb binaries in /usr/bin and whatnot are going to put
argdumper in the same place. argdumper is way too generic a name. Rename to
lldb-argdumper
